Week 3: Jotto Code Review


Below are some thoughts regarding last week's Jotto assignment and code review:


  1. I worked with Luis Hernandez (I reviewed his code) and Edward Torres (he reviewed my code).

  2. Edward mentioned my code was well written and organized. Only suggestion was to include a header with comments at the beginning of the file. He mentioned he liked the way I used a hashmap for the getLetterCount method instead of a for loop.

  3. I would add more comments at the beginning. Also, I would rewrite some of the variable and method names so that less documentation is needed to explain what they hold/do.

  4. The hardest to pass was getLetterCount, but mostly because I didn’t notice the test was testing a word with capital letters (I was handling this elsewhere in the code).

  5. Looks like there needs to be a test for the guess() and play() methods. Between the two of them, they handle a lot of important functionality (or at least direct a lot of it).

  6. I wouldn’t say I struggled the most with understanding the expected functionality of the program before I started coding. It was hard to grasp initially because so many methods are interdependent with each other. But once I understood this, the coding went smoothly.

  7. My teammates all seemed to think getLetterCount was tricky to implement, particularly when it comes to counting letters that match multiple times.

  8. I’m most proud of my getLetterCount function because I used hashmaps to avoid using nested for loops. While the efficiency gained wouldn’t help much in this program (words are limited to 5 characters anyway), it was nice to find an O(n) solution.

Comments

Post a Comment

Popular posts from this blog

Module 4

 Part One: Educational Goals My goal in the CS program is to gain a well-rounded computer science skillset that will prepare me for a career as a software engineer. Looking at course descriptions for courses available within the program, and my own experience outside the classroom, I believe this goal is achievable. I also plan to complete at least one internship by the end of next summer. Based on conversations with recruiters, I've learned that internship experience will greatly increase my chances of obtaining a full-time position. Also, I see it as part of my education, since it would involve learning new skills that I can use towards a future career. I'm planning on applying to as many companies as possible and practicing questions related to data structures and algorithms. Part Two: Career Goals My career goals after graduation are to become a software engineer at a tech company. Once I become a software engineer, I plan to keep learning outside of work, brushing up on so
Read more

Module 8

 OLI Review: This week we took a post test for the OLI material. I found it easier to identify conflict, and and to respond to it properly. Going through the post test questions, I understood why the material is so useful and applicable to team scenarios throughout the course. Luckily, I was assigned to a great team, and haven't had to use any of the conflict resolution methods mentioned in the OLI. Part 1: Video Evaluations of Other Teams Super4 Web Solutions Videos: https://www.youtube.com/watch?v=tdvpwHH512I https://www.youtube.com/watch?v=BF65ge1WfYw Evaluation: The topic is well covered and researched. Video production wasn't too bad for the quality expected, and the presentation was clear. I found the video interesting and all members appear to have planned their speaking parts well. Both videos are appropriate to their audiences. Bit Of Otter Videos: https://www.youtube.com/watch?v=xRcDnYiPm48 https://www.youtube.com/watch?v=XuCseqYcNAg Evaluation: The topic is well cove
Read more

Module 3

OLI Summary: This week I learned about my work style within groups. I find it hard to define myself as one type of member, but I do try to be detailed-oriented and get a task done right when I can. But I alternate between getting it done right or getting it done fast, depending on what the situation calls for. I think the detriment to each style comes from being inflexible in light of other factors. Which approach I take depends on the deadline of a task, the difficulty, and the collective abilities of all members. Part 1 - Link to tips The strategy that needed the most improvement from last week was learning to schedule study time. For this week, I looked at study tips for time management. The best tips were learning how to prioritize, and how to combine several activities. I have noticed that grouping the right activities together makes it easier to finish similar tasks. I also need to prioritize the most important tasks and spend less time on those that are less important (or save t
Read more